Issue 10701146: Make VersionSolver actually return PackageIds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10701146: Make VersionSolver actually return PackageIds. (Closed)

Created:
8 years, 5 months ago by nweiz

Modified:
8 years, 5 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make VersionSolver actually return PackageIds. Committed: https://code.google.com/p/dart/source/detail?r=9574

Patch Set 2 : Style change #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -12 lines)			Patch
	M	utils/pub/version_solver.dart	View	1	2 chunks	+5 lines, -11 lines	0 comments	Download
	M	utils/tests/pub/version_solver_test.dart	View		1 chunk	+8 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

I'm not sure why this didn't make it into my original CL that made VersionSolver ...

8 years, 5 months ago (2012-07-11 21:26:23 UTC) #1

Bob Nystrom

Nit, but LGTM! https://chromiumcodereview.appspot.com/10701146/diff/3001/utils/tests/pub/version_solver_test.dart File utils/tests/pub/version_solver_test.dart (right): https://chromiumcodereview.appspot.com/10701146/diff/3001/utils/tests/pub/version_solver_test.dart#newcode279 utils/tests/pub/version_solver_test.dart:279: return true; return result.isEmpty();

8 years, 5 months ago (2012-07-11 22:51:02 UTC) #2