Issue 10701110: TBR fix my fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10701110: TBR fix my fix (Closed)

Created:
8 years, 5 months ago by devoncarew

Modified:
8 years, 5 months ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

TBR fix my fix Committed: https://code.google.com/p/dart/source/detail?r=9449

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -17 lines)			Patch
	M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	1	4 chunks	+3 lines, -17 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 5 months ago (2012-07-09 13:46:56 UTC) #3

LGTM

http://codereview.chromium.org/10701110/diff/3/compiler/java/com/google/dart/...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

http://codereview.chromium.org/10701110/diff/3/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/parser/DartParser.java:134: final int
MAX_DEFAULT_ERRORS = Short.MAX_VALUE;
Out of curiosity, what prompted the change to the limit?

Expand Messages | Collapse Messages