Some enhancements of PrettyPrinter for NodeList, LiteralList.

Some enhancements of PrettyPrinter for NodeList, LiteralList.

Committed: https://code.google.com/p/dart/source/detail?r=9437

[Roman, 2012-07-06 10:13:56]

Fixed subject.

[Anton Muhin, 2012-07-06 10:19:07]

lgtm

https://chromiumcodereview.appspot.com/10701090/diff/1/lib/compiler/implement...
File lib/compiler/implementation/tree/prettyprint.dart (right):

https://chromiumcodereview.appspot.com/10701090/diff/1/lib/compiler/implement...
lib/compiler/implementation/tree/prettyprint.dart:204: if (token == null) {
nit: === instead of == and single line:

if (token === null) return null;

Another option:

tTSON(Token token) => token === null ? null : token.stringValue;

https://chromiumcodereview.appspot.com/10701090/diff/1/lib/compiler/implement...
lib/compiler/implementation/tree/prettyprint.dart:249: "delimiter" :
node.delimiter != null ? node.delimiter.stringValue : null,
nit: !==

And apparently you can use your function above for it.

https://chromiumcodereview.appspot.com/10701090/diff/1/lib/compiler/implement...
lib/compiler/implementation/tree/prettyprint.dart:284: if (node !== null) {
another option: if (node === null) return;

https://chromiumcodereview.appspot.com/10701090/diff/1/lib/compiler/implement...
lib/compiler/implementation/tree/prettyprint.dart:355: "endToken" :
"${node.endToken.stringValue}"
that applies to the diff above as well: I believe you should stick to
get{Begin,End}Token.

[Roman, 2012-07-06 11:28:32]

https://chromiumcodereview.appspot.com/10701090/diff/1/lib/compiler/implement...
File lib/compiler/implementation/tree/prettyprint.dart (right):

https://chromiumcodereview.appspot.com/10701090/diff/1/lib/compiler/implement...
lib/compiler/implementation/tree/prettyprint.dart:204: if (token == null) {
On 2012/07/06 10:19:07, antonmuhin wrote:
> nit: === instead of == and single line:
> 
> if (token === null) return null;
> 
> Another option:
> 
> tTSON(Token token) => token === null ? null : token.stringValue;

Done.

https://chromiumcodereview.appspot.com/10701090/diff/1/lib/compiler/implement...
lib/compiler/implementation/tree/prettyprint.dart:249: "delimiter" :
node.delimiter != null ? node.delimiter.stringValue : null,
On 2012/07/06 10:19:07, antonmuhin wrote:
> nit: !==
> 
> And apparently you can use your function above for it.

Done. delimiter is a SourceString, not a Token.

https://chromiumcodereview.appspot.com/10701090/diff/1/lib/compiler/implement...
lib/compiler/implementation/tree/prettyprint.dart:284: if (node !== null) {
On 2012/07/06 10:19:07, antonmuhin wrote:
> another option: if (node === null) return;

Done.

https://chromiumcodereview.appspot.com/10701090/diff/1/lib/compiler/implement...
lib/compiler/implementation/tree/prettyprint.dart:355: "endToken" :
"${node.endToken.stringValue}"
On 2012/07/06 10:19:07, antonmuhin wrote:
> that applies to the diff above as well: I believe you should stick to
> get{Begin,End}Token.

Done. Changed everywhere.