Properly capture and pass the stack trace in Future exceptions.

Properly capture and pass the stack trace in Future exceptions.

Committed: https://code.google.com/p/dart/source/detail?r=9378

[Siggi Cherem (dart-lang), 2012-07-03 19:13:46]

lgtm

https://chromiumcodereview.appspot.com/10701084/diff/1/corelib/src/implementa...
File corelib/src/implementation/future_implementation.dart (right):

https://chromiumcodereview.appspot.com/10701084/diff/1/corelib/src/implementa...
corelib/src/implementation/future_implementation.dart:182: } catch (Exception
ex, final stackTrace) {
weird, why is this needed? what if it was 'var' or we omit any annotation here?

[nweiz, 2012-07-03 21:39:26]

https://chromiumcodereview.appspot.com/10701084/diff/1/corelib/src/implementa...
File corelib/src/implementation/future_implementation.dart (right):

https://chromiumcodereview.appspot.com/10701084/diff/1/corelib/src/implementa...
corelib/src/implementation/future_implementation.dart:182: } catch (Exception
ex, final stackTrace) {
On 2012/07/03 19:13:46, sigmund wrote:
> weird, why is this needed? what if it was 'var' or we omit any annotation
here?

With "var" or "final", the stack trace isn't captured. "catch (ex" doesn't
compile at all. Only "Exception" works. I have no idea why this is the case.

[Siggi Cherem (dart-lang), 2012-07-03 22:10:06]

https://chromiumcodereview.appspot.com/10701084/diff/1/corelib/src/implementa...
File corelib/src/implementation/future_implementation.dart (right):

https://chromiumcodereview.appspot.com/10701084/diff/1/corelib/src/implementa...
corelib/src/implementation/future_implementation.dart:182: } catch (Exception
ex, final stackTrace) {
On 2012/07/03 21:39:26, nweiz wrote:
> On 2012/07/03 19:13:46, sigmund wrote:
> > weird, why is this needed? what if it was 'var' or we omit any annotation
> here?
> 
> With "var" or "final", the stack trace isn't captured. "catch (ex" doesn't
> compile at all. Only "Exception" works. I have no idea why this is the case.

weird... if you haven't already, file a bug on the VM about this issue.