Issue 10701078: Print even less.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10701078: Print even less. (Closed)

Created:
8 years, 5 months ago by Anton Muhin

Modified:
8 years, 5 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Print even less. That helped for Linux and Mac. Let's see if it'll help on Windows. R=ricow@google.com BUG=3834 Committed: https://code.google.com/p/dart/source/detail?r=9335

Patch Set 2 : Rebased #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	tests/corelib/corelib.status	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
	M	tests/corelib/sort_helper.dart	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM https://chromiumcodereview.appspot.com/10701078/diff/1/tests/corelib/corelib.status File tests/corelib/corelib.status (left): https://chromiumcodereview.appspot.com/10701078/diff/1/tests/corelib/corelib.status#oldcode82 tests/corelib/corelib.status:82: list_sort_test: Fail, Pass # Issue 2667 You probably ...

8 years, 5 months ago (2012-07-03 09:36:59 UTC) #1

Anton Muhin

8 years, 5 months ago (2012-07-03 11:01:45 UTC) #2

https://chromiumcodereview.appspot.com/10701078/diff/1/tests/corelib/corelib....
File tests/corelib/corelib.status (left):

https://chromiumcodereview.appspot.com/10701078/diff/1/tests/corelib/corelib....
tests/corelib/corelib.status:82: list_sort_test: Fail, Pass # Issue 2667
Thanks, will do.

On 2012/07/03 09:36:59, ricow1 wrote:
> You probably need to rebaseline, I changed these lines this morning

Expand Messages | Collapse Messages

Issue 10701078: Print even less. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Rebased #

Messages