Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1212)

Issue 10701011: No compile-time error when overriding a static field or method (Closed)

Created:
8 years, 5 months ago by zundel
Modified:
8 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, Brian Wilkerson
Visibility:
Public.

Description

No compile-time error when overriding a static field or method In some cases, you need a warning though Issue 3659 http://code.google.com/p/dart/issues/detail?id=3659 Issue 3779 http://code.google.com/p/dart/issues/detail?id=3779 Committed: https://code.google.com/p/dart/source/detail?r=9191

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -43 lines) Patch
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 4 chunks +47 lines, -38 lines 1 comment Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTestCase.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language.status View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
zundel
https://chromiumcodereview.appspot.com/10701011/diff/1/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right): https://chromiumcodereview.appspot.com/10701011/diff/1/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java#newcode2665 compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:2665: && !superElement.getModifiers().isStatic()) { A static member in the superclass ...
8 years, 5 months ago (2012-06-27 21:30:58 UTC) #1
scheglov
8 years, 5 months ago (2012-06-27 21:42:27 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698