Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 10700146: Issue 4040. Fix NPE when report problem with no node. (Closed)

Created:
8 years, 5 months ago by scheglov
Modified:
8 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 4040. Fix NPE when report problem with no node. http://code.google.com/p/dart/issues/detail?id=4040 Clean up after previous quick build fixes. Can not reproduce actual rename problem, but it may be caused by exception during parsing which this CL is fixing. R=brianwilkerson@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9522

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -10 lines) Patch
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 4 chunks +11 lines, -9 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java View 1 chunk +14 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/completion/CompletionEngineTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 5 months ago (2012-07-10 18:46:34 UTC) #1
Brian Wilkerson
8 years, 5 months ago (2012-07-10 19:01:44 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698