Issue 10700123: Remove the instruction pointer from computations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10700123: Remove the instruction pointer from computations. (Closed)

Created:
8 years, 5 months ago by Kevin Millikin (Google)

Modified:
8 years, 5 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Remove the instruction pointer from computations. Remove the back pointers from computations to instructions in favor of passing the instruction explicitly when needed. R=fschneider@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9435

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -73 lines)			Patch
M	runtime/vm/flow_graph_optimizer.h	View	1 chunk	+19 lines, -13 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	20 chunks	+48 lines, -37 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	8 chunks	+5 lines, -12 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	2 chunks	+2 lines, -11 lines	0 comments	Download

Total messages: 2 (0 generated)

Kevin Millikin (Google)

Since we always reach a computation by coming from the instruction wrapping it, this bit ...

8 years, 5 months ago (2012-07-06 10:29:22 UTC) #1

lgtm