Issue 10700122: Generalize the use of type information for setters and initializers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10700122: Generalize the use of type information for setters and initializers (Closed)

Created:
8 years, 5 months ago by Søren Gjesse

Modified:
8 years, 5 months ago

Reviewers:
floitsch, Mads Ager (google), ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Generalize the use of type information for setters and initializers Instead of checking explicitly for integers just union the types involved. This also led to some refactoring getting rid of an almost duplicate method. R=floitsch@google.com, ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9426

Patch Set 1 #

Total comments: 3

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -31 lines)			Patch
	M	lib/compiler/implementation/compiler.dart	View		2 chunks	+7 lines, -20 lines	0 comments	Download
	M	lib/compiler/implementation/ssa/optimize.dart	View		1 chunk	+10 lines, -11 lines	3 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://chromiumcodereview.appspot.com/10700122/diff/1/lib/compiler/implementation/ssa/optimize.dart File lib/compiler/implementation/ssa/optimize.dart (right): https://chromiumcodereview.appspot.com/10700122/diff/1/lib/compiler/implementation/ssa/optimize.dart#newcode1239 lib/compiler/implementation/ssa/optimize.dart:1239: // signal to indiate the expected type of ...

8 years, 5 months ago (2012-07-06 09:06:51 UTC) #3

ngeoffray

8 years, 5 months ago (2012-07-11 12:48:43 UTC) #4

https://chromiumcodereview.appspot.com/10700122/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/optimize.dart (right):

https://chromiumcodereview.appspot.com/10700122/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/optimize.dart:1240: left.propagatedType = type;
Isn't that covered by visitFieldGet already?

https://chromiumcodereview.appspot.com/10700122/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/optimize.dart:1245: left.guaranteedType = type;
ditto?

Expand Messages | Collapse Messages