Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 10700113: Have a "fast" ie-windows bot and a slower ie-windows bot. (Closed)

Created:
8 years, 5 months ago by Emily Fortuna
Modified:
8 years, 5 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Have a "fast" ie-windows bot and a slower ie-windows bot. Committed: https://code.google.com/p/dart/source/detail?r=9418

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M utils/compiler/buildbot.py View 2 chunks +24 lines, -6 lines 4 comments Download

Messages

Total messages: 4 (0 generated)
Emily Fortuna
https://chromiumcodereview.appspot.com/10700113/diff/1/utils/compiler/buildbot.py File utils/compiler/buildbot.py (right): https://chromiumcodereview.appspot.com/10700113/diff/1/utils/compiler/buildbot.py#newcode221 utils/compiler/buildbot.py:221: 'vm', 'json', 'benchmark_smoke', 'dartdoc', 'utils', 'pub', 'lib'], alternatively, instead ...
8 years, 5 months ago (2012-07-05 10:18:02 UTC) #1
ricow1
LGTM https://chromiumcodereview.appspot.com/10700113/diff/1/utils/compiler/buildbot.py File utils/compiler/buildbot.py (right): https://chromiumcodereview.appspot.com/10700113/diff/1/utils/compiler/buildbot.py#newcode193 utils/compiler/buildbot.py:193: flags = filter(lambda(item): not item.startswith('--shard'), flags) + ['-j1'] ...
8 years, 5 months ago (2012-07-05 11:10:39 UTC) #2
Emily Fortuna
https://chromiumcodereview.appspot.com/10700113/diff/1/utils/compiler/buildbot.py File utils/compiler/buildbot.py (right): https://chromiumcodereview.appspot.com/10700113/diff/1/utils/compiler/buildbot.py#newcode193 utils/compiler/buildbot.py:193: flags = filter(lambda(item): not item.startswith('--shard'), flags) + ['-j1'] On ...
8 years, 5 months ago (2012-07-05 12:01:28 UTC) #3
ricow1
8 years, 5 months ago (2012-07-05 12:04:49 UTC) #4
https://chromiumcodereview.appspot.com/10700113/diff/1/utils/compiler/buildbo...
File utils/compiler/buildbot.py (right):

https://chromiumcodereview.appspot.com/10700113/diff/1/utils/compiler/buildbo...
utils/compiler/buildbot.py:193: flags = filter(lambda(item): not
item.startswith('--shard'), flags) + ['-j1']
On 2012/07/05 12:01:28, Emily Fortuna wrote:
> On 2012/07/05 11:10:39, ricow1 wrote:
> > you might also want to remove --shards to not have any confusion.
> 
> this will remove both --shard= and --shards=
oh, .startswith, sorry

Powered by Google App Engine
This is Rietveld 408576698