Issue 10700101: First experimental steps towards a better story for JS interop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10700101: First experimental steps towards a better story for JS interop. (Closed)

Created:
8 years, 5 months ago by kasperl

Modified:
8 years, 5 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

First experimental steps towards a better story for JS interop. R=vsm@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9387

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+395 lines, -13 lines)			Patch
M	client/dart.js	View		1 chunk	+84 lines, -0 lines	0 comments	Download
M	lib/dom/templates/html/frog/html_frog.darttemplate	View	1	3 chunks	+43 lines, -1 line	0 comments	Download
M	lib/dom/templates/html/frog/impl_Window.darttemplate	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	lib/html/frog/html_frog.dart	View		5 chunks	+242 lines, -0 lines	0 comments	Download
M	lib/isolate/frog/messages.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/isolate/isolate_api.dart	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	tests/html/html.status	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/html/js_interop_2_test.dart	View	1	3 chunks	+10 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

8 years, 5 months ago (2012-07-04 08:52:35 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10700101/diff/1/lib/dom/templates/html...
File lib/dom/templates/html/frog/html_frog.darttemplate (right):

https://chromiumcodereview.appspot.com/10700101/diff/1/lib/dom/templates/html...
lib/dom/templates/html/frog/html_frog.darttemplate:51: 
Let's add a comment here:

TODO(vsm): Move this to a separate Isolates.dart file.

https://chromiumcodereview.appspot.com/10700101/diff/1/tests/html/js_interop_...
File tests/html/js_interop_2_test.dart (right):

https://chromiumcodereview.appspot.com/10700101/diff/1/tests/html/js_interop_...
tests/html/js_interop_2_test.dart:9: #import('dart:json');
Can delete this now.

Expand Messages | Collapse Messages