Issue 10700089: Another round of JUnit tests to finish off ResovlerErrorCodes I could reproduce

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10700089: Another round of JUnit tests to finish off ResovlerErrorCodes I could reproduce (Closed)

Created:
8 years, 5 months ago by zundel

Modified:
8 years, 5 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Another round of JUnit tests to finish off ResovlerErrorCodes I could reproduce Committed: https://code.google.com/p/dart/source/detail?r=9373

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+187 lines, -41 lines)			Patch
M	compiler/java/com/google/dart/compiler/resolver/Resolver.java	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java	View	3 chunks	+8 lines, -22 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View	7 chunks	+11 lines, -19 lines	1 comment	Download
M	compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java	View	1 chunk	+137 lines, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	2 chunks	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zundel

http://codereview.chromium.org/10700089/diff/1/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (left): http://codereview.chromium.org/10700089/diff/1/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java#oldcode1083 compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:1083: if (badBoundIsError) { I could not find any way ...

8 years, 5 months ago (2012-07-03 18:22:09 UTC) #2

LGTM. Thanks for doing this!

Expand Messages | Collapse Messages