Add a goto instruction to the IL use it to terminate basic blocks.

Add a goto instruction to the IL use it to terminate basic blocks.

Having an explicit control instruction at the end of each
basic block allows to easily remove instructions inside
a block because the last_instruction pointer can not change.
Committed: https://code.google.com/p/dart/source/detail?r=9253

[Vyacheslav Egorov (Google), 2012-06-29 16:06:03]

lgtm

https://chromiumcodereview.appspot.com/10700034/diff/1/vm/flow_graph_builder.cc
File vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/10700034/diff/1/vm/flow_graph_builder....
vm/flow_graph_builder.cc:82: if (is_empty()) {
I find a bit confusing that a lot of code is duplicated between AddInstruction
and AddBlockEntry. 

We need to factor that out.

https://chromiumcodereview.appspot.com/10700034/diff/1/vm/flow_graph_builder....
vm/flow_graph_builder.cc:1210: back_target_entry->SetSuccessor(new
GotoInstr(body_entry_join));
SetSuccessor(new GotoInstr()) could have been turned into a helper

ConnectWithGoto(source, target).

https://chromiumcodereview.appspot.com/10700034/diff/1/vm/intermediate_langua...
File vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10700034/diff/1/vm/intermediate_langua...
vm/intermediate_language.h:2387: virtual LocationSummary* locs()  { return NULL;
}
() {

single space

[Florian Schneider, 2012-06-29 16:13:12]

Agree. I'll do the refactoring part in a separate CL.

https://chromiumcodereview.appspot.com/10700034/diff/1/vm/intermediate_langua...
File vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10700034/diff/1/vm/intermediate_langua...
vm/intermediate_language.h:2387: virtual LocationSummary* locs()  { return NULL;
}
On 2012/06/29 16:06:03, Vyacheslav Egorov (Google) wrote:
> () {
> 
> single space

Done.