Issue 10699068: Add numerous features to the Pub test infrastructure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10699068: Add numerous features to the Pub test infrastructure. (Closed)

Created:
8 years, 5 months ago by nweiz

Modified:
8 years, 5 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add numerous features to the Pub test infrastructure. Committed: https://code.google.com/p/dart/source/detail?r=9368

Patch Set 1 #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+258 lines, -110 lines)			Patch
M	utils/pub/io.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	utils/pub/utils.dart	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	utils/tests/pub/pub_test.dart	View	10 chunks	+28 lines, -16 lines	0 comments	Download
M	utils/tests/pub/test_pub.dart	View	19 chunks	+211 lines, -94 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

lgtm https://chromiumcodereview.appspot.com/10699068/diff/1/utils/tests/pub/test_pub.dart File utils/tests/pub/test_pub.dart (right): https://chromiumcodereview.appspot.com/10699068/diff/1/utils/tests/pub/test_pub.dart#newcode622 utils/tests/pub/test_pub.dart:622: Future commit(parentDir) { anyone using this yet?

8 years, 5 months ago (2012-07-03 02:03:10 UTC) #2

nweiz

8 years, 5 months ago (2012-07-03 18:04:49 UTC) #3

https://chromiumcodereview.appspot.com/10699068/diff/1/utils/tests/pub/test_p...
File utils/tests/pub/test_pub.dart (right):

https://chromiumcodereview.appspot.com/10699068/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:622: Future commit(parentDir) {
On 2012/07/03 02:03:10, John Messerly wrote:
> anyone using this yet?

No, all these changes are going to be used in a future commit.

Expand Messages | Collapse Messages