Issue 10698154: Fix getters/setters unparsing, they appeared as ordinary methods without get/set keywords.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10698154: Fix getters/setters unparsing, they appeared as ordinary methods without get/set keywords. (Closed)

Created:
8 years, 5 months ago by Roman

Modified:
8 years, 5 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix getters/setters unparsing, they appeared as ordinary methods without get/set keywords. Committed: https://code.google.com/p/dart/source/detail?r=9551

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -21 lines)			Patch
	M	lib/compiler/implementation/dart_backend/backend.dart	View		2 chunks	+33 lines, -21 lines	1 comment	Download
	M	tests/compiler/dart2js/unparser_test.dart	View		3 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

8 years, 5 months ago (2012-07-11 15:40:28 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10698154/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10698154/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:66: void
outputElement(Element element, StringBuffer sb) {
maybe it's time to introduce emitter class instead of threading string buffer
around.

Expand Messages | Collapse Messages