Issue 10698128: Improve code for checked instance calls (polymorphic calls) and expand printing of PolymorphicInsta…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10698128: Improve code for checked instance calls (polymorphic calls) and expand printing of PolymorphicInsta… (Closed)

Created:
8 years, 5 months ago by srdjan

Modified:
8 years, 5 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Improve code for checked instance calls (polymorphic calls) and expand printing of PolymorphicInstanceCall to include checked class names. Committed: https://code.google.com/p/dart/source/detail?r=9520

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 2

Patch Set 6 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -23 lines)			Patch
M	runtime/vm/flow_graph_compiler.cc	View	1 2 3 4 5	3 chunks	+15 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/il_printer.cc	View	1 2 3 4	1 chunk	+18 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3 4	3 chunks	+6 lines, -7 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3 4	3 chunks	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10698128/diff/2004/runtime/vm/flow_graph_compiler.cc File runtime/vm/flow_graph_compiler.cc (right): https://chromiumcodereview.appspot.com/10698128/diff/2004/runtime/vm/flow_graph_compiler.cc#newcode393 runtime/vm/flow_graph_compiler.cc:393: char buffer[255]; Why not 256?

8 years, 5 months ago (2012-07-10 18:07:42 UTC) #2

srdjan

8 years, 5 months ago (2012-07-10 18:16:10 UTC) #3

https://chromiumcodereview.appspot.com/10698128/diff/2004/runtime/vm/flow_gra...
File runtime/vm/flow_graph_compiler.cc (right):

https://chromiumcodereview.appspot.com/10698128/diff/2004/runtime/vm/flow_gra...
runtime/vm/flow_graph_compiler.cc:393: char buffer[255];
On 2012/07/10 18:07:42, regis wrote:
> Why not 256?

Done.

Expand Messages | Collapse Messages