Issue 10698096: Reapply "Make patch file import declarations apply to the patched library too."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10698096: Reapply "Make patch file import declarations apply to the patched library too." (Closed)

Created:
8 years, 5 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 5 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply "Make patch file import declarations apply to the patched library too." This reapplies r9346 with the following fix: Adds #library tag to tests containing #import. The test web-driver tries to source the file if it doesn't contain a #library declaration, which isn't valid if it contains #import. R=floitsch Committed: https://code.google.com/p/dart/source/detail?r=9401

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -36 lines)			Patch
M	lib/compiler/implementation/compiler.dart	View	3 chunks	+31 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/elements/elements.dart	View	1 chunk	+8 lines, -1 line	0 comments	Download
A	lib/compiler/implementation/lib/math.dartp	View	1 chunk	+12 lines, -0 lines	0 comments	Download
D	lib/compiler/implementation/lib/web.dart	View	1 chunk	+0 lines, -9 lines	0 comments	Download
D	lib/compiler/implementation/lib/web.dartp	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	lib/compiler/implementation/library_map.dart	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/scanner/scanner_task.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	tests/compiler/dart2js_extra/math_lib_prefix_test.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
A +	tests/compiler/dart2js_extra/math_lib_test.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download