Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 10698079: Revert all the changes to equals operator. Causing buildbot trouble. (Closed)

Created:
8 years, 5 months ago by Mads Ager (google)
Modified:
8 years, 5 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert all the changes to equals operator. Causing buildbot trouble. R=floitsch@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -15 lines) Patch
M lib/compiler/implementation/lib/js_helper.dart View 3 chunks +27 lines, -5 lines 0 comments Download
M lib/compiler/implementation/ssa/builder.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/compiler/implementation/ssa/codegen.dart View 2 chunks +13 lines, -0 lines 0 comments Download
M lib/compiler/implementation/ssa/nodes.dart View 1 chunk +1 line, -3 lines 0 comments Download
M lib/compiler/implementation/ssa/optimize.dart View 1 chunk +22 lines, -0 lines 0 comments Download
M tests/co19/co19-leg.status View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/boolified_operator_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/constant_folding_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/operator5_test.dart View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
8 years, 5 months ago (2012-07-03 15:38:52 UTC) #1
floitsch
8 years, 5 months ago (2012-07-03 15:42:41 UTC) #2
sad but LGTM.

Powered by Google App Engine
This is Rietveld 408576698