Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 10698056: Omit '= null' as default value in generated dart:html code. (Closed)

Created:
8 years, 5 months ago by sra1
Modified:
8 years, 5 months ago
Reviewers:
Anton Muhin
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Omit '= null' as default value in generated dart:html code. Committed: https://code.google.com/p/dart/source/detail?r=9303

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+454 lines, -454 lines) Patch
M lib/dom/dom.dart View 6 chunks +8 lines, -8 lines 0 comments Download
M lib/dom/frog/dom_frog.dart View 93 chunks +190 lines, -190 lines 0 comments Download
M lib/dom/scripts/generator.py View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/dartium/html_dartium.dart View 46 chunks +70 lines, -70 lines 0 comments Download
M lib/html/frog/html_frog.dart View 93 chunks +185 lines, -185 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
8 years, 5 months ago (2012-06-29 20:36:42 UTC) #1
Anton Muhin
8 years, 5 months ago (2012-07-02 09:38:28 UTC) #2
lgtm and thanks

Powered by Google App Engine
This is Rietveld 408576698