Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 10698051: Fix Dart_RemoveBreakpoint (Closed)

Created:
8 years, 5 months ago by hausner
Modified:
8 years, 5 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix Dart_RemoveBreakpoint The debugger code assumed that breakpoints can only be removed while the debugger is paused. That is not true. An embedder can remove breakpoints while the isolate is idle and running any Dart code. Fix for issue 3781 (http://dartbug.com/3781) Committed: https://code.google.com/p/dart/source/detail?r=9258

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M runtime/vm/debugger.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
hausner
8 years, 5 months ago (2012-06-29 17:56:04 UTC) #1
regis
8 years, 5 months ago (2012-06-29 18:03:20 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698