Issue 10698025: Fix dartc status files and error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10698025: Fix dartc status files and error. (Closed)

Created:
8 years, 5 months ago by Emily Fortuna

Modified:
8 years, 5 months ago

Reviewers:
Alan Knight

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix dartc status files and error. Committed: https://code.google.com/p/dart/source/detail?r=9194

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -35 lines)			Patch
	M	lib/i18n/date_format.dart	View		1 chunk	+37 lines, -33 lines	1 comment	Download
	M	tests/lib/lib.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alan Knight

8 years, 5 months ago (2012-06-28 00:05:03 UTC) #2

https://chromiumcodereview.appspot.com/10698025/diff/1/lib/i18n/date_format.dart
File lib/i18n/date_format.dart (right):

https://chromiumcodereview.appspot.com/10698025/diff/1/lib/i18n/date_format.d...
lib/i18n/date_format.dart:175: DateFormat.Hm([locale=this._locale]) :
_formatDefinition = Hm;
If this syntax works, ok, but I don't understand it, and it doesn't seem to work
for me if I do a trivial example in that form.

The thing I did in the very long-running change to make date-formatting work was
change it to "this.locale" and provide a setter locale for the _locale variable,
and a getter that returned it or en_US if unset.

Expand Messages | Collapse Messages