Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 10697096: Add "external" prefix to methods and constructors. (Closed)

Created:
8 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
8 years, 4 months ago
Reviewers:
ahe, floitsch
CC:
reviews_dartlang.org, ahe, gbracha
Visibility:
Public.

Description

Add "external" prefix to methods and constructors. This is expected to be added to the language specification, for allowing the specification of methods with externally bound implementations. Committed: https://code.google.com/p/dart/source/detail?r=9456

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -18 lines) Patch
M lib/compiler/implementation/elements/elements.dart View 1 chunk +7 lines, -2 lines 0 comments Download
M lib/compiler/implementation/scanner/keyword.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M lib/compiler/implementation/scanner/listener.dart View 3 chunks +9 lines, -4 lines 2 comments Download
M lib/compiler/implementation/scanner/parser.dart View 5 chunks +12 lines, -5 lines 2 comments Download
M lib/compiler/implementation/tree/nodes.dart View 5 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
8 years, 5 months ago (2012-07-06 13:09:46 UTC) #1
floitsch
LGTM.
8 years, 5 months ago (2012-07-06 15:12:14 UTC) #2
ahe
I'd like to get this cleaned up. https://chromiumcodereview.appspot.com/10697096/diff/1/lib/compiler/implementation/scanner/listener.dart File lib/compiler/implementation/scanner/listener.dart (left): https://chromiumcodereview.appspot.com/10697096/diff/1/lib/compiler/implementation/scanner/listener.dart#oldcode1417 lib/compiler/implementation/scanner/listener.dart:1417: handleModifiers(1); This ...
8 years, 4 months ago (2012-08-02 20:14:36 UTC) #3
ahe
8 years, 4 months ago (2012-08-23 16:06:05 UTC) #4
I'll clean this up myself.

Powered by Google App Engine
This is Rietveld 408576698