Recognize "patch" identifier in .dartp files.

Recognize "patch" identifier in .dartp files.

Added more infrastructure to detect errors in the patch.
Still no ability to add an element from the patch to the original library.

Committed: https://code.google.com/p/dart/source/detail?r=9457

[Johnni Winther, 2012-07-06 07:57:39]

LGTM with comments.

https://chromiumcodereview.appspot.com/10697084/diff/1/lib/compiler/implement...
File lib/compiler/implementation/compiler.dart (right):

https://chromiumcodereview.appspot.com/10697084/diff/1/lib/compiler/implement...
lib/compiler/implementation/compiler.dart:599: // TODO(lrn): More checks needed
if we introduce matadata for real.
matadata -> metadata

https://chromiumcodereview.appspot.com/10697084/diff/1/lib/compiler/implement...
lib/compiler/implementation/compiler.dart:604:
"${patchElement.name.slowToString()}'.");
I can't see the relation between 1) the element having a non-empty metadata, 2)
it being a patch, AND 3) being a non-existing member. Why does 1) imply 2) and
3)?

https://chromiumcodereview.appspot.com/10697084/diff/1/lib/compiler/implement...
lib/compiler/implementation/compiler.dart:619: bool isPatch(Element element) {
Make a separate isPatch check to be used both in clonePatch and patchMember to
avoid redundancy.

[Lasse Reichstein Nielsen, 2012-07-06 10:26:23]

https://chromiumcodereview.appspot.com/10697084/diff/1/lib/compiler/implement...
File lib/compiler/implementation/compiler.dart (right):

https://chromiumcodereview.appspot.com/10697084/diff/1/lib/compiler/implement...
lib/compiler/implementation/compiler.dart:599: // TODO(lrn): More checks needed
if we introduce matadata for real.
On 2012/07/06 07:57:39, Johnni Winther wrote:
> matadata -> metadata

Done.

https://chromiumcodereview.appspot.com/10697084/diff/1/lib/compiler/implement...
lib/compiler/implementation/compiler.dart:604:
"${patchElement.name.slowToString()}'.");
This function is for copying a declaration from the patch library to the patchee
library, which mustn't have a declaration of that name yet. The patch
declaration must not be marked as "patch", because then it's intended to replace
an existing element. I've added a more elaborate comment to explain that.
I'll move the test, so we don't get here with a patch-patch declaration.

https://chromiumcodereview.appspot.com/10697084/diff/1/lib/compiler/implement...
lib/compiler/implementation/compiler.dart:619: bool isPatch(Element element) {
Done. I consider moving everything to patch-parser to keep the related functions
together, and not infect Compiler with too many methods.

[floitsch, 2012-07-06 11:53:32]

LGTM.