Split backend.AddMembers call into series of backend.AddAtribute/backend.AddOperation calls.

Split backend.AddMembers call into series of backend.AddAtribute/backend.AddOperation calls.

R=antonm@google.com,sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=9425

[Anton Muhin, 2012-07-04 16:42:39]

https://chromiumcodereview.appspot.com/10697080/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/10697080/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:935: self._backend.StartGeneratingMergedMembers()
I think it's too hacky, esp. this mute all the emitters part.

As a suggestion, maybe you should change API to produce a merged members
generator?  html backend may return itself, dartium one will return something
which does nothing.  Just as an idea

https://chromiumcodereview.appspot.com/10697080/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:949: self._backend.AddAttribute(attribute)
nit: move to the end of the method, plz

[podivilov, 2012-07-04 17:44:05]

https://chromiumcodereview.appspot.com/10697080/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/10697080/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:935: self._backend.StartGeneratingMergedMembers()
On 2012/07/04 16:42:39, antonmuhin wrote:
> I think it's too hacky, esp. this mute all the emitters part.
> 
> As a suggestion, maybe you should change API to produce a merged members
> generator?  html backend may return itself, dartium one will return something
> which does nothing.  Just as an idea

Done.

https://chromiumcodereview.appspot.com/10697080/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:949: self._backend.AddAttribute(attribute)
On 2012/07/04 16:42:39, antonmuhin wrote:
> nit: move to the end of the method, plz

I don't want to mess with early returns in this method, at least for now. See
https://chromiumcodereview.appspot.com/10704102/.

[Anton Muhin, 2012-07-04 20:03:17]

https://chromiumcodereview.appspot.com/10697080/diff/5001/lib/dom/scripts/sys...
File lib/dom/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/10697080/diff/5001/lib/dom/scripts/sys...
lib/dom/scripts/systemhtml.py:935: backend = self._backend
nit: backend -> old_backend

https://chromiumcodereview.appspot.com/10697080/diff/5001/lib/dom/scripts/sys...
lib/dom/scripts/systemhtml.py:941: self._backend = backend
I am slightly uneasy that you mutate internal state, any chances this ugliness
may go away now or later?

[podivilov, 2012-07-05 09:13:43]

https://chromiumcodereview.appspot.com/10697080/diff/5001/lib/dom/scripts/sys...
File lib/dom/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/10697080/diff/5001/lib/dom/scripts/sys...
lib/dom/scripts/systemhtml.py:935: backend = self._backend
On 2012/07/04 20:03:17, antonmuhin wrote:
> nit: backend -> old_backend

Done.

https://chromiumcodereview.appspot.com/10697080/diff/5001/lib/dom/scripts/sys...
lib/dom/scripts/systemhtml.py:941: self._backend = backend
On 2012/07/04 20:03:17, antonmuhin wrote:
> I am slightly uneasy that you mutate internal state, any chances this ugliness
> may go away now or later?

Why HtmlDartInterfaceGenerator shouldn't mutate it's own internal state? I can
pass the backend down through AddMembers to all AddFoo methods, but imo it
wouldn't make the code better.

I'm not sure if we need merged members in dart2js implementation classes.
Removing them may help to simplify this later.

[Anton Muhin, 2012-07-05 16:07:00]

lgtm

https://chromiumcodereview.appspot.com/10697080/diff/5003/lib/dom/scripts/sys...
File lib/dom/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/10697080/diff/5003/lib/dom/scripts/sys...
lib/dom/scripts/systemhtml.py:1131: def ImplementsMergedMembers(self):
that could probably be a simple field