Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 10697068: Change dart2js to follow the new spec on the equality operator. (Closed)

Created:
8 years, 5 months ago by Mads Ager (google)
Modified:
8 years, 5 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change dart2js to follow the new spec on the equality operator. 'null' is only equals to 'null' and nothing else. The user-defined operator== is never called with null. This also means that a 'a == null' and 'null == a' can always be treated as a builtin when compiling to javascript. Update the test expectations for co19. I will file co19 bugs about updating the tests. R=floitsch@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9348

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -68 lines) Patch
M lib/compiler/implementation/lib/js_helper.dart View 3 chunks +5 lines, -27 lines 0 comments Download
M lib/compiler/implementation/ssa/builder.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M lib/compiler/implementation/ssa/codegen.dart View 2 chunks +0 lines, -13 lines 0 comments Download
M lib/compiler/implementation/ssa/nodes.dart View 1 chunk +3 lines, -1 line 0 comments Download
M lib/compiler/implementation/ssa/optimize.dart View 1 chunk +0 lines, -22 lines 0 comments Download
M tests/co19/co19-leg.status View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/language/operator5_test.dart View 2 chunks +2 lines, -1 line 1 comment Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
8 years, 5 months ago (2012-07-03 13:28:54 UTC) #1
floitsch
8 years, 5 months ago (2012-07-03 13:35:29 UTC) #2
LGTM.

https://chromiumcodereview.appspot.com/10697068/diff/1/tests/language/operato...
File tests/language/operator5_test.dart (right):

https://chromiumcodereview.appspot.com/10697068/diff/1/tests/language/operato...
tests/language/operator5_test.dart:57: equalsNull(a);
hehe.

Powered by Google App Engine
This is Rietveld 408576698