MutationObserver

Add MutationObserver constructor
Add custom MutationObserver.observe method

The observe method supports configuration by dictionary and optional arguments:

observer.observe(node, {'subtree': true});
observer.observe(node, subtree: true);

If both are given, they are merged.

Committed: https://code.google.com/p/dart/source/detail?r=9752

[sra1, 2012-07-13 08:17:45]

On 2012/07/13 08:15:39, sra1 wrote:

It is no longer true that Dartium should need a custom method.
WebKit parses the Dictionary so it should work fine so long as Dartium can
convert the Dart Map object into a Dictionary.

[Anton Muhin, 2012-07-13 10:50:47]

I am responding on email thread regarding the general approach.

https://chromiumcodereview.appspot.com/10696209/diff/6012/lib/dom/dom.dart
File lib/dom/dom.dart (right):

https://chromiumcodereview.appspot.com/10696209/diff/6012/lib/dom/dom.dart#ne...
lib/dom/dom.dart:11849: interface WebKitMutationObserver default
_WebKitMutationObserverFactoryProvider {
btw, there is no more WebKitMutationObserver, only plain MutationObserver.

https://chromiumcodereview.appspot.com/10696209/diff/6012/lib/dom/idl/dart/da...
File lib/dom/idl/dart/dart.idl (right):

https://chromiumcodereview.appspot.com/10696209/diff/6012/lib/dom/idl/dart/da...
lib/dom/idl/dart/dart.idl:296: [DartName=_observe] void observe(in Node target,
in Dictionary options)
as you probably already know, that's exactly the signature in WebKit idl:
http://trac.webkit.org/browser/trunk/Source/WebCore/dom/MutationObserver.idl?...

https://chromiumcodereview.appspot.com/10696209/diff/6012/lib/dom/templates/h...
File lib/dom/templates/html/impl/impl_MutationObserver.darttemplate (right):

https://chromiumcodereview.appspot.com/10696209/diff/6012/lib/dom/templates/h...
lib/dom/templates/html/impl/impl_MutationObserver.darttemplate:22: if
(_boolKeys.containsKey(k)) {
maybe simplify it too: if k != 'attributeFilter' ?

https://chromiumcodereview.appspot.com/10696209/diff/6012/lib/dom/templates/h...
lib/dom/templates/html/impl/impl_MutationObserver.darttemplate:38:
override('childList', childList);
as another option:

override(key, value) {
  if (value != null) _add(parsedOptions, key, value);
  if (options !=null && options.containsKey(key)) _add(parsedOptions, key,
options[key]);
}

that will apparently render obsolete the whole loop above and _boolKeys stuff

[sra1, 2012-07-19 00:34:54]

https://chromiumcodereview.appspot.com/10696209/diff/6012/lib/dom/dom.dart
File lib/dom/dom.dart (right):

https://chromiumcodereview.appspot.com/10696209/diff/6012/lib/dom/dom.dart#ne...
lib/dom/dom.dart:11849: interface WebKitMutationObserver default
_WebKitMutationObserverFactoryProvider {
On 2012/07/13 10:50:47, Anton Mukhin wrote:
> btw, there is no more WebKitMutationObserver, only plain MutationObserver.

This is the DOM library - if it doesn't work we no longer care.  The IDL still
defines WebKitMutationObserver at the time of this CL

https://chromiumcodereview.appspot.com/10696209/diff/6012/lib/dom/idl/dart/da...
File lib/dom/idl/dart/dart.idl (right):

https://chromiumcodereview.appspot.com/10696209/diff/6012/lib/dom/idl/dart/da...
lib/dom/idl/dart/dart.idl:296: [DartName=_observe] void observe(in Node target,
in Dictionary options)
On 2012/07/13 10:50:47, Anton Mukhin wrote:
> as you probably already know, that's exactly the signature in WebKit idl:
>
http://trac.webkit.org/browser/trunk/Source/WebCore/dom/MutationObserver.idl?...

Yes.  To copy the extended attribute DartName onto the operation it must be the
matching overload.

https://chromiumcodereview.appspot.com/10696209/diff/6012/lib/dom/templates/h...
File lib/dom/templates/html/impl/impl_MutationObserver.darttemplate (right):

https://chromiumcodereview.appspot.com/10696209/diff/6012/lib/dom/templates/h...
lib/dom/templates/html/impl/impl_MutationObserver.darttemplate:38:
override('childList', childList);
On 2012/07/13 10:50:47, Anton Mukhin wrote:
> as another option:
> 
> override(key, value) {
>   if (value != null) _add(parsedOptions, key, value);
>   if (options !=null && options.containsKey(key)) _add(parsedOptions, key,
> options[key]);
> }
> 
> that will apparently render obsolete the whole loop above and _boolKeys stuff

When we get experience with a couple of these 'bag of options' APIs we might
look at generating them automatically.
I think longer term I want the (generated) code to be very simple so that a
compiler can tell that there is a big benefit to specializing these functions.
That is one reason to keep 'options != null' at the top level.

[vsm, 2012-07-19 01:12:30]

lgtm

https://chromiumcodereview.appspot.com/10696209/diff/22001/tests/html/mutatio...
File tests/html/mutationobserver_test.dart (right):

https://chromiumcodereview.appspot.com/10696209/diff/22001/tests/html/mutatio...
tests/html/mutationobserver_test.dart:1: // Copyright (c) 2011, the Dart project
authors.  Please see the AUTHORS file
2012