Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10696191: Frog removed from dartdoc. (Closed)

Created:
8 years, 5 months ago by Johnni Winther
Modified:
8 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Frog removed from dartdoc. Committed: https://code.google.com/p/dart/source/detail?r=9590

Patch Set 1 #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18191 lines) Patch
D lib/dartdoc/frog/analyze.dart View 1 chunk +0 lines, -793 lines 0 comments Download
D lib/dartdoc/frog/analyze_frame.dart View 1 chunk +0 lines, -175 lines 0 comments Download
D lib/dartdoc/frog/block_scope.dart View 1 chunk +0 lines, -222 lines 0 comments Download
D lib/dartdoc/frog/code_writer.dart View 1 chunk +0 lines, -110 lines 0 comments Download
D lib/dartdoc/frog/corejs.dart View 1 chunk +0 lines, -642 lines 0 comments Download
D lib/dartdoc/frog/element.dart View 1 chunk +0 lines, -183 lines 0 comments Download
D lib/dartdoc/frog/evaluator.dart View 1 chunk +0 lines, -132 lines 0 comments Download
D lib/dartdoc/frog/file_system.dart View 1 chunk +0 lines, -73 lines 0 comments Download
D lib/dartdoc/frog/file_system_dom.dart View 1 chunk +0 lines, -81 lines 0 comments Download
D lib/dartdoc/frog/file_system_memory.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D lib/dartdoc/frog/file_system_vm.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D lib/dartdoc/frog/frog_leg.dart View 1 chunk +0 lines, -72 lines 0 comments Download
D lib/dartdoc/frog/frog_options.dart View 1 chunk +0 lines, -211 lines 0 comments Download
D lib/dartdoc/frog/frogc.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D lib/dartdoc/frog/gen.dart View 1 chunk +0 lines, -2545 lines 0 comments Download
D lib/dartdoc/frog/lang.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D lib/dartdoc/frog/lib/arrays.dart View 1 chunk +0 lines, -66 lines 0 comments Download
D lib/dartdoc/frog/lib/corelib.dart View 1 chunk +0 lines, -132 lines 0 comments Download
D lib/dartdoc/frog/lib/corelib_impl.dart View 1 chunk +0 lines, -529 lines 0 comments Download
D lib/dartdoc/frog/lib/date_implementation.dart View 1 chunk +0 lines, -301 lines 0 comments Download
D lib/dartdoc/frog/lib/function_implementation.dart View 1 chunk +0 lines, -94 lines 0 comments Download
D lib/dartdoc/frog/lib/math.dart View 1 chunk +0 lines, -106 lines 0 comments Download
D lib/dartdoc/frog/lib/natives.dart View 1 chunk +0 lines, -70 lines 0 comments Download
D lib/dartdoc/frog/lib/num.dart View 1 chunk +0 lines, -61 lines 0 comments Download
D lib/dartdoc/frog/lib/string_base.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D lib/dartdoc/frog/lib/string_buffer.dart View 1 chunk +0 lines, -84 lines 0 comments Download
D lib/dartdoc/frog/lib/string_implementation.dart View 1 chunk +0 lines, -184 lines 0 comments Download
D lib/dartdoc/frog/library.dart View 1 chunk +0 lines, -509 lines 0 comments Download
D lib/dartdoc/frog/member.dart View 1 chunk +0 lines, -1444 lines 0 comments Download
D lib/dartdoc/frog/member_set.dart View 1 chunk +0 lines, -304 lines 0 comments Download
D lib/dartdoc/frog/method_data.dart View 1 chunk +0 lines, -148 lines 0 comments Download
D lib/dartdoc/frog/minfrogc.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D lib/dartdoc/frog/parser.dart View 1 chunk +0 lines, -1748 lines 0 comments Download
D lib/dartdoc/frog/reader.dart View 1 chunk +0 lines, -94 lines 0 comments Download
D lib/dartdoc/frog/source.dart View 1 chunk +0 lines, -186 lines 0 comments Download
D lib/dartdoc/frog/token.dart View 1 chunk +0 lines, -60 lines 0 comments Download
D lib/dartdoc/frog/token_kind.g.dart View 1 chunk +0 lines, -585 lines 0 comments Download
D lib/dartdoc/frog/tokenizer.dart View 1 chunk +0 lines, -482 lines 0 comments Download
D lib/dartdoc/frog/tokenizer.g.dart View 1 chunk +0 lines, -426 lines 0 comments Download
D lib/dartdoc/frog/tree.dart View 1 chunk +0 lines, -131 lines 0 comments Download
D lib/dartdoc/frog/tree.g.dart View 1 chunk +0 lines, -947 lines 0 comments Download
D lib/dartdoc/frog/type.dart View 1 chunk +0 lines, -1220 lines 0 comments Download
D lib/dartdoc/frog/utils.dart View 1 chunk +0 lines, -179 lines 0 comments Download
D lib/dartdoc/frog/value.dart View 1 chunk +0 lines, -1665 lines 0 comments Download
D lib/dartdoc/frog/var_member.dart View 1 chunk +0 lines, -276 lines 0 comments Download
D lib/dartdoc/frog/world.dart View 1 chunk +0 lines, -715 lines 0 comments Download
M tools/create_sdk.py View 1 chunk +0 lines, -10 lines 8 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
Defrogging is done!
8 years, 5 months ago (2012-07-12 10:32:26 UTC) #1
Lasse Reichstein Nielsen
STV https://chromiumcodereview.appspot.com/10696191/diff/1/tools/create_sdk.py File tools/create_sdk.py (right): https://chromiumcodereview.appspot.com/10696191/diff/1/tools/create_sdk.py#newcode41 tools/create_sdk.py:41: # ........{frog, runtime}/ Remove reference to frog here. ...
8 years, 5 months ago (2012-07-12 11:01:45 UTC) #2
Johnni Winther
8 years, 5 months ago (2012-07-13 11:25:19 UTC) #3 
https://chromiumcodereview.appspot.com/10696191/diff/1/tools/create_sdk.py
File tools/create_sdk.py (right):

https://chromiumcodereview.appspot.com/10696191/diff/1/tools/create_sdk.py#ne...
tools/create_sdk.py:41: # ........{frog, runtime}/
On 2012/07/12 11:01:46, Lasse Reichstein Nielsen wrote:
> Remove reference to frog here.

Not related to dartdoc usage. Probably still valid.

https://chromiumcodereview.appspot.com/10696191/diff/1/tools/create_sdk.py#ne...
tools/create_sdk.py:53: # ........{frog}/
On 2012/07/12 11:01:46, Lasse Reichstein Nielsen wrote:
> And here.

Not related to dartdoc usage. Probably still valid.

https://chromiumcodereview.appspot.com/10696191/diff/1/tools/create_sdk.py#ne...
tools/create_sdk.py:312: join(html_dest_dir, 'html_frog.dart'))
On 2012/07/12 11:01:46, Lasse Reichstein Nielsen wrote:
> What is this frog?

This has to do with the current html implementation. It's only called frog
because it's that old.

https://chromiumcodereview.appspot.com/10696191/diff/1/tools/create_sdk.py#ne...
tools/create_sdk.py:326: join(dom_dest_dir, 'dom_frog.dart'))
On 2012/07/12 11:01:46, Lasse Reichstein Nielsen wrote:
> And this?
The same.

Powered by Google App Engine
This is Rietveld 408576698