Issue 10696183: Add some missing x64 instruction variations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10696183: Add some missing x64 instruction variations. (Closed)

Created:
8 years, 5 months ago by srdjan

Modified:
8 years, 5 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add some missing x64 instruction variations. Committed: https://code.google.com/p/dart/source/detail?r=9578

Patch Set 3 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+295 lines, -13 lines)			Patch
M	runtime/vm/assembler_x64.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1	5 chunks	+41 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_x64_test.cc	View	1 2	5 chunks	+244 lines, -3 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1	5 chunks	+5 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10696183/diff/6001/runtime/vm/assembler_x64_test.cc File runtime/vm/assembler_x64_test.cc (left): https://chromiumcodereview.appspot.com/10696183/diff/6001/runtime/vm/assembler_x64_test.cc#oldcode717 runtime/vm/assembler_x64_test.cc:717: Why not keep this 32-bit version and add ...

8 years, 5 months ago (2012-07-12 00:24:28 UTC) #2

srdjan

8 years, 5 months ago (2012-07-12 00:34:38 UTC) #3

Thanks.

https://chromiumcodereview.appspot.com/10696183/diff/6001/runtime/vm/assemble...
File runtime/vm/assembler_x64_test.cc (left):

https://chromiumcodereview.appspot.com/10696183/diff/6001/runtime/vm/assemble...
runtime/vm/assembler_x64_test.cc:717: 
On 2012/07/12 00:24:28, regis wrote:
> Why not keep this 32-bit version and add a LogicalOps64?

Done.

Expand Messages | Collapse Messages

Issue 10696183: Add some missing x64 instruction variations. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages