Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 10696155: Allocate types in proper heap space. (Closed)

Created:
8 years, 5 months ago by regis
Modified:
8 years, 5 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allocate types in proper heap space. Allow type finalization without canonicalization. Committed: https://code.google.com/p/dart/source/detail?r=9529

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -93 lines) Patch
M runtime/vm/class_finalizer.h View 1 2 1 chunk +9 lines, -7 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 1 2 17 chunks +29 lines, -21 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M runtime/vm/object.h View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M runtime/vm/object.cc View 1 2 7 chunks +44 lines, -40 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 14 chunks +18 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
regis
8 years, 5 months ago (2012-07-10 19:05:56 UTC) #1
Ivan Posva
8 years, 5 months ago (2012-07-10 21:34:42 UTC) #2
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698