Issue 10696120: Fix very subtle bug in HNode.changeUse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10696120: Fix very subtle bug in HNode.changeUse. (Closed)

Created:
8 years, 5 months ago by floitsch

Modified:
8 years, 5 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix very subtle bug in HNode.changeUse. Committed: https://code.google.com/p/dart/source/detail?r=9441

Patch Set 2 : Address comments. #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -6 lines)			Patch
	M	lib/compiler/implementation/ssa/nodes.dart	View	1	3 chunks	+9 lines, -6 lines	0 comments	Download
	A	tests/language/partial_min_test.dart	View		1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

LGTM and good catch. https://chromiumcodereview.appspot.com/10696120/diff/1/lib/compiler/implementation/ssa/nodes.dart File lib/compiler/implementation/ssa/nodes.dart (right): https://chromiumcodereview.appspot.com/10696120/diff/1/lib/compiler/implementation/ssa/nodes.dart#newcode938 lib/compiler/implementation/ssa/nodes.dart:938: oldInputUsers.length = oldInputUsers.length - 1; ...

8 years, 5 months ago (2012-07-06 11:22:16 UTC) #2

floitsch

8 years, 5 months ago (2012-07-06 15:20:33 UTC) #3

https://chromiumcodereview.appspot.com/10696120/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/10696120/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/nodes.dart:938: oldInputUsers.length =
oldInputUsers.length - 1;
On 2012/07/06 11:22:16, Lasse Reichstein Nielsen wrote:
> Use 'oldInputUsers.length -= 1' here, or even 'oldInputUsers.length--'.
done.
> 
> If order is irrelevant, and duplicates probably irrelevant, why do we use a
List
> and not a Set?
I'm not sure duplicates are irrelevant. Maybe another CL.

Expand Messages | Collapse Messages

Issue 10696120: Fix very subtle bug in HNode.changeUse. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comments. #

Messages