Issue 10696112: Fix status for new interop tests on IE, FF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10696112: Fix status for new interop tests on IE, FF (Closed)

Created:
8 years, 5 months ago by vsm

Modified:
8 years, 5 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix status for new interop tests on IE, FF TBR'ing to green the bots. TBR=kasperl Committed: https://code.google.com/p/dart/source/detail?r=9397

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	tests/html/html.status	View		2 chunks	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kasperl

8 years, 5 months ago (2012-07-04 11:43:20 UTC) #2

LGTM, but

https://chromiumcodereview.appspot.com/10696112/diff/1/tests/html/html.status
File tests/html/html.status (right):

https://chromiumcodereview.appspot.com/10696112/diff/1/tests/html/html.status...
tests/html/html.status:113: js_interop_2_test: Pass, Fail  # Passes on Linux,
Fails on Windows.
You could also keep this under a [ $runtime == ff && $system == windows ]
section and make it Fail only. At least then we'll know if it ever starts
failing on Linux.

Expand Messages | Collapse Messages