Initial tests for JS interop

Initial tests for JS interop

BUG=625
Committed: https://code.google.com/p/dart/source/detail?r=9384

[kasperl, 2012-07-04 05:13:00]

LGTM.

https://chromiumcodereview.appspot.com/10696092/diff/1/client/dart.js
File client/dart.js (right):

https://chromiumcodereview.appspot.com/10696092/diff/1/client/dart.js#newcode37
client/dart.js:37: window._$dart$initialized = true;
Let's add a comment here that explains what the purpose of this is. As it is
now, it looks kinda fishy.

https://chromiumcodereview.appspot.com/10696092/diff/1/tests/html/html.status
File tests/html/html.status (right):

https://chromiumcodereview.appspot.com/10696092/diff/1/tests/html/html.status...
tests/html/html.status:10: js_interop_2_test: Skip  # Issue 625
Can't we mark this as failing instead ... or does it hang?

https://chromiumcodereview.appspot.com/10696092/diff/1/tests/html/js_interop_...
File tests/html/js_interop_1_test.dart (right):

https://chromiumcodereview.appspot.com/10696092/diff/1/tests/html/js_interop_...
tests/html/js_interop_1_test.dart:1: #library('JsInterop1Test');
Add copyright notice.

https://chromiumcodereview.appspot.com/10696092/diff/1/tests/html/js_interop_...
tests/html/js_interop_1_test.dart:19: callback = expectAsync1((e) {
Too much indentation: Use 2 spaces here.

https://chromiumcodereview.appspot.com/10696092/diff/1/tests/html/js_interop_...
tests/html/js_interop_1_test.dart:20: Expect.equals('hello', e.data);
Too much indentation. Use 2 spaces here.

https://chromiumcodereview.appspot.com/10696092/diff/1/tests/html/js_interop_...
tests/html/js_interop_1_test.dart:22: });
Don't indent this.

https://chromiumcodereview.appspot.com/10696092/diff/1/tests/html/js_interop_...
File tests/html/js_interop_2_test.dart (right):

https://chromiumcodereview.appspot.com/10696092/diff/1/tests/html/js_interop_...
tests/html/js_interop_2_test.dart:1: #library('JsInterop2Test');
Add copyright notice.

https://chromiumcodereview.appspot.com/10696092/diff/1/tests/html/js_interop_...
tests/html/js_interop_2_test.dart:28: callback = expectAsync1((e) {
The indentation is a bit messed up here too (all closures).

https://chromiumcodereview.appspot.com/10696092/diff/1/tests/html/js_interop_...
tests/html/js_interop_2_test.dart:41: Expect.equals('received', result);
Check that port.call('fish') is null?

[vsm, 2012-07-04 07:43:09]

thanks, landing.

https://chromiumcodereview.appspot.com/10696092/diff/1/client/dart.js
File client/dart.js (right):

https://chromiumcodereview.appspot.com/10696092/diff/1/client/dart.js#newcode37
client/dart.js:37: window._$dart$initialized = true;
Removed.  I'd been using it to verify this script was executed prior to each
test being run.  When we add *PortSync here, that'll effectively test this
again.

On 2012/07/04 05:13:00, kasperl wrote:
> Let's add a comment here that explains what the purpose of this is. As it is
> now, it looks kinda fishy.

https://chromiumcodereview.appspot.com/10696092/diff/1/tests/html/html.status
File tests/html/html.status (right):

https://chromiumcodereview.appspot.com/10696092/diff/1/tests/html/html.status...
tests/html/html.status:10: js_interop_2_test: Skip  # Issue 625
On 2012/07/04 05:13:00, kasperl wrote:
> Can't we mark this as failing instead ... or does it hang?

Done.

https://chromiumcodereview.appspot.com/10696092/diff/1/tests/html/js_interop_...
File tests/html/js_interop_1_test.dart (right):

https://chromiumcodereview.appspot.com/10696092/diff/1/tests/html/js_interop_...
tests/html/js_interop_1_test.dart:1: #library('JsInterop1Test');
On 2012/07/04 05:13:00, kasperl wrote:
> Add copyright notice.

Done.

https://chromiumcodereview.appspot.com/10696092/diff/1/tests/html/js_interop_...
tests/html/js_interop_1_test.dart:19: callback = expectAsync1((e) {
On 2012/07/04 05:13:00, kasperl wrote:
> Too much indentation: Use 2 spaces here.

Done.

https://chromiumcodereview.appspot.com/10696092/diff/1/tests/html/js_interop_...
tests/html/js_interop_1_test.dart:20: Expect.equals('hello', e.data);
On 2012/07/04 05:13:00, kasperl wrote:
> Too much indentation. Use 2 spaces here.

Done.

https://chromiumcodereview.appspot.com/10696092/diff/1/tests/html/js_interop_...
tests/html/js_interop_1_test.dart:22: });
On 2012/07/04 05:13:00, kasperl wrote:
> Don't indent this.

Done.

https://chromiumcodereview.appspot.com/10696092/diff/1/tests/html/js_interop_...
File tests/html/js_interop_2_test.dart (right):

https://chromiumcodereview.appspot.com/10696092/diff/1/tests/html/js_interop_...
tests/html/js_interop_2_test.dart:1: #library('JsInterop2Test');
On 2012/07/04 05:13:00, kasperl wrote:
> Add copyright notice.

Done.

https://chromiumcodereview.appspot.com/10696092/diff/1/tests/html/js_interop_...
tests/html/js_interop_2_test.dart:28: callback = expectAsync1((e) {
On 2012/07/04 05:13:00, kasperl wrote:
> The indentation is a bit messed up here too (all closures).

Done.

https://chromiumcodereview.appspot.com/10696092/diff/1/tests/html/js_interop_...
tests/html/js_interop_2_test.dart:41: Expect.equals('received', result);
On 2012/07/04 05:13:00, kasperl wrote:
> Check that port.call('fish') is null?

Done.