Issue 10696091: Refactor the message serialization code a bit so we can start playing with it for JS interop purpos…

Issue 10696091: Refactor the message serialization code a bit so we can start playing with it for JS interop purpos… (Closed)

Created:
8 years, 5 months ago by kasperl

Modified:
8 years, 5 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Refactor the message serialization code a bit so we can start playing with it for JS interop purposes. R=vsm@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9383

Patch Set 3 : Remove extra length. #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+280 lines, -235 lines)			Patch
M	lib/isolate/frog/messages.dart	View	1 2	4 chunks	+72 lines, -224 lines	0 comments	Download
M	lib/isolate/frog/ports.dart	View		1 chunk	+11 lines, -11 lines	0 comments	Download
M	lib/isolate/isolate_leg.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	lib/isolate/serialization.dart	View	1	1 chunk	+196 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vsm

lgtm https://chromiumcodereview.appspot.com/10696091/diff/3001/lib/isolate/frog/messages.dart File lib/isolate/frog/messages.dart (right): https://chromiumcodereview.appspot.com/10696091/diff/3001/lib/isolate/frog/messages.dart#newcode56 lib/isolate/frog/messages.dart:56: nit: extra newline https://chromiumcodereview.appspot.com/10696091/diff/3001/lib/isolate/frog/messages.dart#newcode90 lib/isolate/frog/messages.dart:90: nit: extra newline ...

8 years, 5 months ago (2012-07-04 05:21:54 UTC) #2

kasperl

8 years, 5 months ago (2012-07-04 05:50:14 UTC) #3

https://chromiumcodereview.appspot.com/10696091/diff/3001/lib/isolate/frog/me...
File lib/isolate/frog/messages.dart (right):

https://chromiumcodereview.appspot.com/10696091/diff/3001/lib/isolate/frog/me...
lib/isolate/frog/messages.dart:136: for (int i = 0, length = tagged.length; i <
length; i++) {
On 2012/07/04 05:21:54, vsm wrote:
> Redundant length = tagged.length.

Done.

https://chromiumcodereview.appspot.com/10696091/diff/3001/lib/isolate/frog/me...
lib/isolate/frog/messages.dart:143: "o['__MessageTraverser__attached_info__'] =
(void 0);";
On 2012/07/04 05:21:54, vsm wrote:
> I think this leaves the property on the object.  This should clear it
> altogether:
> delete o['__MessageTraverser__attached_info__']

This is intentional. We don't want to force the object into dictionary mode.

Expand Messages | Collapse Messages