Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 10696090: Add deoptimization environments to instructions. (Closed)

Created:
8 years, 5 months ago by Florian Schneider
Modified:
8 years, 5 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Kevin Millikin (Google)
Visibility:
Public.

Description

Add deoptimization environments to instructions. Each instruction that can deoptimize need to have the values of the non-optimizing code as uses. The values are stored in an environment (GrowableArray<Value*>) attached to the instruction when constructing SSA form. For now every instructions gets a deoptimization environment. It contains the values of all locals, parameters and expression stack elements at the start of the instruction. The environment is not used yet, but can be printed in the flow graph with the flag --print-environments. Committed: https://code.google.com/p/dart/source/detail?r=9345

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -19 lines) Patch
M vm/flow_graph_builder.cc View 3 chunks +37 lines, -18 lines 0 comments Download
M vm/il_printer.cc View 4 chunks +16 lines, -0 lines 0 comments Download
M vm/intermediate_language.h View 4 chunks +31 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Florian Schneider
8 years, 5 months ago (2012-07-03 11:24:00 UTC) #1
Vyacheslav Egorov (Google)
8 years, 5 months ago (2012-07-03 12:40:31 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698