Issue 10696035: Extract common logic for element factory constructors generation.

Issue 10696035: Extract common logic for element factory constructors generation. (Closed)

Created:
8 years, 5 months ago by podivilov

Modified:
8 years, 5 months ago

Reviewers:
Anton Muhin, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Extract common logic for element factory constructors generation. R=antonm@google.com,sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=9292

Patch Set 2 : . #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -77 lines)			Patch
M	lib/dom/scripts/systemhtml.py	View	1	4 chunks	+11 lines, -11 lines	0 comments	Download
M	lib/dom/scripts/systemnative.py	View	1	3 chunks	+3 lines, -11 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		3 chunks	+55 lines, -55 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

neat, one question about naming https://chromiumcodereview.appspot.com/10696035/diff/1/lib/dom/scripts/systemhtml.py File lib/dom/scripts/systemhtml.py (right): https://chromiumcodereview.appspot.com/10696035/diff/1/lib/dom/scripts/systemhtml.py#newcode1058 lib/dom/scripts/systemhtml.py:1058: def FactoryConstructorElementClassName(self): too long ...

8 years, 5 months ago (2012-06-28 13:24:23 UTC) #2

podivilov

https://chromiumcodereview.appspot.com/10696035/diff/1/lib/dom/scripts/systemhtml.py File lib/dom/scripts/systemhtml.py (right): https://chromiumcodereview.appspot.com/10696035/diff/1/lib/dom/scripts/systemhtml.py#newcode1058 lib/dom/scripts/systemhtml.py:1058: def FactoryConstructorElementClassName(self): On 2012/06/28 13:24:23, antonmuhin wrote: > too ...

8 years, 5 months ago (2012-06-29 13:53:39 UTC) #3

lgtm

Expand Messages | Collapse Messages