Issue 10696013: Consider upper bounds of type parameters in type checks.

Issue 10696013: Consider upper bounds of type parameters in type checks. (Closed)

Created:
8 years, 5 months ago by regis

Modified:
8 years, 5 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Consider upper bounds of type parameters in type checks. Fix pointer visiting in TypeParameter. Make TypeParameter::index() non-virtual. Committed: https://code.google.com/p/dart/source/detail?r=9188

Patch Set 1 #

Total comments: 4

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+146 lines, -109 lines)			Patch
M	runtime/vm/class_finalizer.cc	View	4 chunks	+16 lines, -16 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/object.h	View	9 chunks	+18 lines, -17 lines	0 comments	Download
M	runtime/vm/object.cc	View	24 chunks	+78 lines, -50 lines	2 comments	Download
M	runtime/vm/parser.cc	View	4 chunks	+21 lines, -19 lines	2 comments	Download
M	runtime/vm/raw_object.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/raw_object.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM with a couple of formatting nits. https://chromiumcodereview.appspot.com/10696013/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://chromiumcodereview.appspot.com/10696013/diff/1/runtime/vm/object.cc#newcode2704 runtime/vm/object.cc:2704: false); // ...

8 years, 5 months ago (2012-06-27 19:59:40 UTC) #2

regis

8 years, 5 months ago (2012-06-27 20:06:50 UTC) #3

Thanks

https://chromiumcodereview.appspot.com/10696013/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/10696013/diff/1/runtime/vm/object.cc#n...
runtime/vm/object.cc:2704: false);  // Bounds are only checked at the top level.
On 2012/06/27 19:59:40, hausner wrote:
> Indentation

I think the indentation is correct.

https://chromiumcodereview.appspot.com/10696013/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://chromiumcodereview.appspot.com/10696013/diff/1/runtime/vm/parser.cc#n...
runtime/vm/parser.cc:3182: check_type_parameter_bounds)) {
On 2012/06/27 19:59:40, hausner wrote:
> Indentation

I think the indentation is correct.

Expand Messages | Collapse Messages