Issue 10695179: Add test for bug in dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10695179: Add test for bug in dart2js. (Closed)

Created:
8 years, 5 months ago by floitsch

Modified:
8 years, 5 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add test for bug in dart2js. Committed: https://code.google.com/p/dart/source/detail?r=9622

Patch Set 2 : Remove print. #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -2 lines)			Patch
M	tests/compiler/dart2js/dart2js.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/compiler/dart2js/is_inference2_test.dart	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/is_inference_test.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

lgtm https://chromiumcodereview.appspot.com/10695179/diff/1/tests/compiler/dart2js/is_inference2_test.dart File tests/compiler/dart2js/is_inference2_test.dart (right): https://chromiumcodereview.appspot.com/10695179/diff/1/tests/compiler/dart2js/is_inference2_test.dart#newcode16 tests/compiler/dart2js/is_inference2_test.dart:16: print(generated); Remove print statement?

8 years, 5 months ago (2012-07-13 05:23:31 UTC) #2

floitsch

8 years, 5 months ago (2012-07-13 08:12:42 UTC) #3

https://chromiumcodereview.appspot.com/10695179/diff/1/tests/compiler/dart2js...
File tests/compiler/dart2js/is_inference2_test.dart (right):

https://chromiumcodereview.appspot.com/10695179/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/is_inference2_test.dart:16: print(generated);
On 2012/07/13 05:23:31, Mads Ager wrote:
> Remove print statement?

Done.

Expand Messages | Collapse Messages

Issue 10695179: Add test for bug in dart2js. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove print. #

Messages