Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10695171: dart2dart fix "get" appearing before type in typed getter. (Closed)

Created:
8 years, 5 months ago by Roman
Modified:
8 years, 5 months ago
Reviewers:
Anton Muhin
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart2dart fix "get" appearing before type in typed getter. Example: String get foo() {return smth;} => get String foo() {return smth;} Committed: https://code.google.com/p/dart/source/detail?r=9587

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix unparser instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M lib/compiler/implementation/dart_backend/emitter.dart View 1 1 chunk +0 lines, -5 lines 0 comments Download
M lib/compiler/implementation/tree/unparser.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/unparser_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Roman
8 years, 5 months ago (2012-07-12 08:49:56 UTC) #1
Anton Muhin
https://chromiumcodereview.appspot.com/10695171/diff/1/lib/compiler/implementation/dart_backend/emitter.dart File lib/compiler/implementation/dart_backend/emitter.dart (right): https://chromiumcodereview.appspot.com/10695171/diff/1/lib/compiler/implementation/dart_backend/emitter.dart#newcode52 lib/compiler/implementation/dart_backend/emitter.dart:52: } else if (element.isSetter() || element.isGetter()) { can you ...
8 years, 5 months ago (2012-07-12 08:58:01 UTC) #2
Roman
https://chromiumcodereview.appspot.com/10695171/diff/1/lib/compiler/implementation/dart_backend/emitter.dart File lib/compiler/implementation/dart_backend/emitter.dart (right): https://chromiumcodereview.appspot.com/10695171/diff/1/lib/compiler/implementation/dart_backend/emitter.dart#newcode52 lib/compiler/implementation/dart_backend/emitter.dart:52: } else if (element.isSetter() || element.isGetter()) { On 2012/07/12 ...
8 years, 5 months ago (2012-07-12 09:25:40 UTC) #3
Anton Muhin
8 years, 5 months ago (2012-07-12 09:32:10 UTC) #4 
neat, lgtm

Powered by Google App Engine
This is Rietveld 408576698