Issue 10695143: Move handleLogicalAndOr to the SsaBranchBuilder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10695143: Move handleLogicalAndOr to the SsaBranchBuilder. (Closed)

Created:
8 years, 5 months ago by floitsch

Modified:
8 years, 5 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move handleLogicalAndOr to the SsaBranchBuilder. Committed: https://code.google.com/p/dart/source/detail?r=9586

Patch Set 1 #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -52 lines)			Patch
	M	lib/compiler/implementation/ssa/builder.dart	View		3 chunks	+54 lines, -52 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

LGTM https://chromiumcodereview.appspot.com/10695143/diff/1/lib/compiler/implementation/ssa/builder.dart File lib/compiler/implementation/ssa/builder.dart (right): https://chromiumcodereview.appspot.com/10695143/diff/1/lib/compiler/implementation/ssa/builder.dart#newcode3489 lib/compiler/implementation/ssa/builder.dart:3489: } Could be shorter by using the stack ...

8 years, 5 months ago (2012-07-12 07:18:25 UTC) #2

floitsch

8 years, 5 months ago (2012-07-12 09:23:30 UTC) #3

https://chromiumcodereview.appspot.com/10695143/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10695143/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/builder.dart:3489: }
On 2012/07/12 07:18:26, Lasse Reichstein Nielsen wrote:
> Could be shorter by using the stack more:
> void visitCondition() {
>  left();
>  boolifiedLeft = builder.popBoolified();
>  builder.stack.add(boolifiedLeft);
>  if (isAnd) {
>    builder.push(new HNot(builder.pop());
>  }
> }
>  
Agreed, but in this CL I'm not going to change any code (unless necessary for it
to work in the new location).

Expand Messages | Collapse Messages