Issue 10695136: Use class id instead of class in subtype test cache.

Issue 10695136: Use class id instead of class in subtype test cache. (Closed)

Created:
8 years, 5 months ago by srdjan

Modified:
8 years, 5 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Use class id instead of class in subtype test cache. Committed: https://code.google.com/p/dart/source/detail?r=9559

Patch Set 7 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -29 lines)			Patch
M	runtime/vm/code_generator.cc	View	1 2 3 4	5 chunks	+11 lines, -7 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2 3 4	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3 4	3 chunks	+7 lines, -4 lines	0 comments	Download
M	runtime/vm/object_test.cc	View	1 2 3 4	1 chunk	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 2 3 4 5 6	3 chunks	+8 lines, -6 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 2 3 4 5 6	2 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10695136/diff/8002/runtime/vm/stub_code_ia32.cc File runtime/vm/stub_code_ia32.cc (right): https://chromiumcodereview.appspot.com/10695136/diff/8002/runtime/vm/stub_code_ia32.cc#newcode1813 runtime/vm/stub_code_ia32.cc:1813: // Get instance type arguments period missing https://chromiumcodereview.appspot.com/10695136/diff/8002/runtime/vm/stub_code_ia32.cc#newcode1836 ...

8 years, 5 months ago (2012-07-11 01:56:48 UTC) #2

srdjan

8 years, 5 months ago (2012-07-11 18:00:40 UTC) #3

https://chromiumcodereview.appspot.com/10695136/diff/8002/runtime/vm/stub_cod...
File runtime/vm/stub_code_ia32.cc (right):

https://chromiumcodereview.appspot.com/10695136/diff/8002/runtime/vm/stub_cod...
runtime/vm/stub_code_ia32.cc:1813: // Get instance type arguments
On 2012/07/11 01:56:48, regis wrote:
> period missing

Done.

https://chromiumcodereview.appspot.com/10695136/diff/8002/runtime/vm/stub_cod...
runtime/vm/stub_code_ia32.cc:1836: // EBX: instance type arguments
On 2012/07/11 01:56:48, regis wrote:
> period missing

Done.

https://chromiumcodereview.appspot.com/10695136/diff/8002/runtime/vm/stub_cod...
File runtime/vm/stub_code_x64.cc (right):

https://chromiumcodereview.appspot.com/10695136/diff/8002/runtime/vm/stub_cod...
runtime/vm/stub_code_x64.cc:1791: // R13: instance type arguments
On 2012/07/11 01:56:48, regis wrote:
> period missing

Done.

Expand Messages | Collapse Messages