Add support for JS->Dart and Dart->dart via *PortSync.

Add support for JS->Dart and Dart->dart via *PortSync.

Committed: https://code.google.com/p/dart/source/detail?r=9427

[kasperl, 2012-07-06 07:48:47]

LGTM.

https://chromiumcodereview.appspot.com/10695111/diff/6001/tests/html/js_inter...
File tests/html/js_interop_3_test.dart (right):

https://chromiumcodereview.appspot.com/10695111/diff/6001/tests/html/js_inter...
tests/html/js_interop_3_test.dart:29: test('js-to-dart', () {
Should we update the description string used in the other interop tests too?
Something like this is better.

https://chromiumcodereview.appspot.com/10695111/diff/6001/tests/html/js_inter...
tests/html/js_interop_3_test.dart:30: var done = expectAsync0(() {});
Maybe move this closer to where it is used? It feels like this should be covered
by the TODO comment.

https://chromiumcodereview.appspot.com/10695111/diff/6001/tests/html/js_inter...
File tests/html/js_interop_4_test.dart (right):

https://chromiumcodereview.appspot.com/10695111/diff/6001/tests/html/js_inter...
tests/html/js_interop_4_test.dart:11: const testData = const [1, '2', 'true'];
This is really new syntax (I don't think this is supported by the VM). Maybe
just used var for now?

https://chromiumcodereview.appspot.com/10695111/diff/6001/tests/html/js_inter...
tests/html/js_interop_4_test.dart:13: class TestIsolate extends Isolate {
This way of creating isolates is deprecated. Any reason why you're still using
it?

https://chromiumcodereview.appspot.com/10695111/diff/6001/tests/html/js_inter...
tests/html/js_interop_4_test.dart:31: Expect.listEquals(testData, message);
Indentation.

https://chromiumcodereview.appspot.com/10695111/diff/6001/tests/html/js_inter...
tests/html/js_interop_4_test.dart:46: var done = expectAsync0(() {});
Maybe move this down to the TODO?

https://chromiumcodereview.appspot.com/10695111/diff/6001/tests/html/js_inter...
tests/html/js_interop_4_test.dart:68: new TestIsolate().spawn().then((p) {});
Hmm. Why do you call 'then' at all?

https://chromiumcodereview.appspot.com/10695111/diff/6002/client/dart.js
File client/dart.js (right):

https://chromiumcodereview.appspot.com/10695111/diff/6002/client/dart.js#newc...
client/dart.js:60: message.receivePort.portId ];
No tabs.

https://chromiumcodereview.appspot.com/10695111/diff/6002/client/dart.js#newc...
client/dart.js:133: var result = ReceivePortSync.map[id].callback(deserialized);
We should really wrap this in a try-catch and find a way of reporting back a
serialized exception.

https://chromiumcodereview.appspot.com/10695111/diff/6002/client/dart.js#newc...
client/dart.js:153: var result =
ReceivePortSync.map[data.id].callback(deserialized);
We should really wrap this in a try-catch.

https://chromiumcodereview.appspot.com/10695111/diff/6002/client/dart.js#newc...
client/dart.js:170: function Dart2JSSendPortSync(isolateId, portId) {
Dart2JsSendPortSync is more readable to me (Js rather than JS).

https://chromiumcodereview.appspot.com/10695111/diff/6002/client/dart.js#newc...
client/dart.js:178: var string = JSON.stringify(message);
Weird indentation.

[vsm, 2012-07-06 08:10:02]

thanks, fixed and landing.

https://chromiumcodereview.appspot.com/10695111/diff/6002/client/dart.js
File client/dart.js (right):

https://chromiumcodereview.appspot.com/10695111/diff/6002/client/dart.js#newc...
client/dart.js:60: message.receivePort.portId ];
Thanks - need to fix my js mode!

On 2012/07/06 07:48:47, kasperl wrote:
> No tabs.

https://chromiumcodereview.appspot.com/10695111/diff/6002/client/dart.js#newc...
client/dart.js:133: var result = ReceivePortSync.map[id].callback(deserialized);
Added TODO.

On 2012/07/06 07:48:47, kasperl wrote:
> We should really wrap this in a try-catch and find a way of reporting back a
> serialized exception.

https://chromiumcodereview.appspot.com/10695111/diff/6002/client/dart.js#newc...
client/dart.js:153: var result =
ReceivePortSync.map[data.id].callback(deserialized);
TODO added to propagate exception.

On 2012/07/06 07:48:47, kasperl wrote:
> We should really wrap this in a try-catch.

https://chromiumcodereview.appspot.com/10695111/diff/6002/client/dart.js#newc...
client/dart.js:170: function Dart2JSSendPortSync(isolateId, portId) {
On 2012/07/06 07:48:47, kasperl wrote:
> Dart2JsSendPortSync is more readable to me (Js rather than JS).

Done.

https://chromiumcodereview.appspot.com/10695111/diff/6002/client/dart.js#newc...
client/dart.js:178: var string = JSON.stringify(message);
On 2012/07/06 07:48:47, kasperl wrote:
> Weird indentation.

Done.