Issue 10695106: Allow === and == to generate inputs at the use site when compiling to a single comparison

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10695106: Allow === and == to generate inputs at the use site when compiling to a single comparison (Closed)

Created:
8 years, 5 months ago by sra1

Modified:
8 years, 5 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow === and == to generate inputs at the use site when compiling to a single comparison. We only need temps in the general case x === y --> (x == null ? y == null : x === y) Committed: https://code.google.com/p/dart/source/detail?r=9481

Patch Set 1 : #

Patch Set 2 : merge #

Total comments: 2

Patch Set 3 : cr fix #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -38 lines)			Patch
	M	lib/compiler/implementation/ssa/codegen.dart	View	1	2 chunks	+38 lines, -32 lines	0 comments	Download
	M	lib/compiler/implementation/ssa/codegen_helpers.dart	View	1 2	1 chunk	+16 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM! https://chromiumcodereview.appspot.com/10695106/diff/4001/lib/compiler/implementation/ssa/codegen_helpers.dart File lib/compiler/implementation/ssa/codegen_helpers.dart (right): https://chromiumcodereview.appspot.com/10695106/diff/4001/lib/compiler/implementation/ssa/codegen_helpers.dart#newcode56 lib/compiler/implementation/ssa/codegen_helpers.dart:56: // at use site if does not require ...

8 years, 5 months ago (2012-07-09 20:02:33 UTC) #2

sra1

8 years, 5 months ago (2012-07-09 20:18:57 UTC) #3

https://chromiumcodereview.appspot.com/10695106/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/ssa/codegen_helpers.dart (right):

https://chromiumcodereview.appspot.com/10695106/diff/4001/lib/compiler/implem...
lib/compiler/implementation/ssa/codegen_helpers.dart:56: // at use site if does
not require an expression with repeated uses (because
On 2012/07/09 20:02:33, floitsch wrote:
> if it

Done.

Expand Messages | Collapse Messages