Issue 10695103: Track users through phi nodes to eliminate '>>> 0' for more bitops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10695103: Track users through phi nodes to eliminate '>>> 0' for more bitops (Closed)

Created:
8 years, 5 months ago by Mads Ager (google)

Modified:
8 years, 5 months ago

Reviewers:
Søren Gjesse, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Track users through phi nodes to eliminate '>>> 0' for more bitops whose results are only used in other bitops. R=kasperl@google.com,sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9413

Patch Set 2 : Address review comment. #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -8 lines)			Patch
	M	lib/compiler/implementation/ssa/codegen.dart	View	1	2 chunks	+15 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/10695103/diff/1/lib/compiler/implementation/ssa/codegen.dart File lib/compiler/implementation/ssa/codegen.dart (right): https://chromiumcodereview.appspot.com/10695103/diff/1/lib/compiler/implementation/ssa/codegen.dart#newcode220 lib/compiler/implementation/ssa/codegen.dart:220: bool hasNonBitOpUsers(HInstruction instruction, Set<HPhi> phiSet) { Users -> ...

8 years, 5 months ago (2012-07-05 08:40:22 UTC) #2

Mads Ager (google)

8 years, 5 months ago (2012-07-05 08:42:34 UTC) #3

https://chromiumcodereview.appspot.com/10695103/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10695103/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/codegen.dart:220: bool
hasNonBitOpUsers(HInstruction instruction, Set<HPhi> phiSet) {
On 2012/07/05 08:40:22, kasperl wrote:
> Users -> User?

Done.

Expand Messages | Collapse Messages

Issue 10695103: Track users through phi nodes to eliminate '>>> 0' for more bitops (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address review comment. #

Messages