Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 10695067: Added a few tests, removed some error codes from Resolver (Closed)

Created:
8 years, 5 months ago by zundel
Modified:
8 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Added a few tests, removed some error codes from Resolver Committed: https://code.google.com/p/dart/source/detail?r=9313

Patch Set 1 #

Total comments: 2

Patch Set 2 : # #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -20 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java View 3 chunks +3 lines, -3 lines 1 comment Download
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 1 2 chunks +1 line, -7 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java View 1 2 chunks +3 lines, -8 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java View 3 chunks +35 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
zundel
https://chromiumcodereview.appspot.com/10695067/diff/1/compiler/java/com/google/dart/compiler/resolver/Resolver.java File compiler/java/com/google/dart/compiler/resolver/Resolver.java (left): https://chromiumcodereview.appspot.com/10695067/diff/1/compiler/java/com/google/dart/compiler/resolver/Resolver.java#oldcode1701 compiler/java/com/google/dart/compiler/resolver/Resolver.java:1701: case LABEL: Labels are in a different namespace, so ...
8 years, 5 months ago (2012-07-02 20:18:06 UTC) #1
Brian Wilkerson
8 years, 5 months ago (2012-07-02 21:17:53 UTC) #2
LGTM

https://chromiumcodereview.appspot.com/10695067/diff/2002/compiler/java/com/g...
File
compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java
(right):

https://chromiumcodereview.appspot.com/10695067/diff/2002/compiler/java/com/g...
compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java:1:
// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

Powered by Google App Engine
This is Rietveld 408576698