Issue 10694151: dart2dart introduce "emitter" that that generates source code.

Issue 10694151: dart2dart introduce "emitter" that that generates source code. (Closed)

Created:
8 years, 5 months ago by Roman

Modified:
8 years, 5 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart2dart introduce "emitter" that that generates source code. Committed: https://code.google.com/p/dart/source/detail?r=9581

Patch Set 2 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -54 lines)			Patch
M	lib/compiler/implementation/dart_backend/backend.dart	View	1	3 chunks	+4 lines, -54 lines	0 comments	Download
M	lib/compiler/implementation/dart_backend/dart_backend.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	lib/compiler/implementation/dart_backend/emitter.dart	View	1	1 chunk	+63 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm and thanks https://chromiumcodereview.appspot.com/10694151/diff/1/lib/compiler/implementation/dart_backend/backend.dart File lib/compiler/implementation/dart_backend/backend.dart (right): https://chromiumcodereview.appspot.com/10694151/diff/1/lib/compiler/implementation/dart_backend/backend.dart#newcode87 lib/compiler/implementation/dart_backend/backend.dart:87: resolvedClassMembers.forEach((classElement, resolvedElements) { nit: rCM.forEach(emitter.outputClass); https://chromiumcodereview.appspot.com/10694151/diff/1/lib/compiler/implementation/dart_backend/emitter.dart ...

8 years, 5 months ago (2012-07-12 07:02:50 UTC) #2

Roman

8 years, 5 months ago (2012-07-12 07:44:54 UTC) #3

https://chromiumcodereview.appspot.com/10694151/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10694151/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:87:
resolvedClassMembers.forEach((classElement, resolvedElements) {
On 2012/07/12 07:02:51, Anton Mukhin wrote:
> nit: rCM.forEach(emitter.outputClass);

Done.

https://chromiumcodereview.appspot.com/10694151/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/emitter.dart (right):

https://chromiumcodereview.appspot.com/10694151/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/emitter.dart:13: Emitter(this.listener)
: sb = new StringBuffer() {}
On 2012/07/12 07:02:51, Anton Mukhin wrote:
> nit: ; instead of ' {}'

Done.

https://chromiumcodereview.appspot.com/10694151/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/emitter.dart:62: String toString() {
On 2012/07/12 07:02:51, Anton Mukhin wrote:
> nit: => syntax, please

Done.

Expand Messages | Collapse Messages