Collect the actual types for all field setters.

Collect the actual types for all field setters.

Before only boolean indicating whether the type was HType.INTEGER or
not was collected. Now collect the union of all types seen for setters
for each field.

R=floitsch@google.com, ager@google.com

BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=9422

[Mads Ager (google), 2012-07-05 13:42:53]

LGTM!

https://chromiumcodereview.appspot.com/10694091/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/optimize.dart (right):

https://chromiumcodereview.appspot.com/10694091/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/optimize.dart:1223: if
((backend.fieldSettersTypeSoFar(left.element).isUnknown() ||
We should probably generalize these things as well. For instance it might make
sense to optimize for numbers as well as only integers?

We can play with that in a separate change.

[Mads Ager (google), 2012-07-05 13:55:19]

https://chromiumcodereview.appspot.com/10694091/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/optimize.dart (right):

https://chromiumcodereview.appspot.com/10694091/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/optimize.dart:1191: if
(!compiler.codegenWorld.hasInvokedSetter(field, compiler)) {
Should this be the resolverWorld? Are you sure that you have seen all setter
invocations at this point?

[Mads Ager (google), 2012-07-05 13:56:53]

https://chromiumcodereview.appspot.com/10694091/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/optimize.dart (right):

https://chromiumcodereview.appspot.com/10694091/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/optimize.dart:1191: if
(!compiler.codegenWorld.hasInvokedSetter(field, compiler)) {
On 2012/07/05 13:55:19, Mads Ager wrote:
> Should this be the resolverWorld? Are you sure that you have seen all setter
> invocations at this point?

Ignore me, this is during recompilation so this is correct. :)

[Søren Gjesse, 2012-07-06 04:10:32]

http://codereview.chromium.org/10694091/diff/1/lib/compiler/implementation/ss...
File lib/compiler/implementation/ssa/optimize.dart (right):

http://codereview.chromium.org/10694091/diff/1/lib/compiler/implementation/ss...
lib/compiler/implementation/ssa/optimize.dart:1223: if
((backend.fieldSettersTypeSoFar(left.element).isUnknown() ||
On 2012/07/05 13:42:53, Mads Ager wrote:
> We should probably generalize these things as well. For instance it might make
> sense to optimize for numbers as well as only integers?
> 
> We can play with that in a separate change.

Will do.