Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 10694082: Add the JS helper function to all libraries where we allow the native syntax. (Closed)

Created:
8 years, 5 months ago by kasperl
Modified:
8 years, 5 months ago
CC:
reviews_dartlang.org, sra1
Visibility:
Public.

Description

Add the JS helper function to all libraries where we allow the native syntax. Try to use the JS helper from somewhere in the HTML library. R=vsm@google.com BUG=http://dartbug.com/3842 TEST= Committed: https://code.google.com/p/dart/source/detail?r=9409

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M lib/compiler/implementation/native_handler.dart View 1 chunk +1 line, -5 lines 1 comment Download
M lib/dom/templates/html/frog/html_frog.darttemplate View 1 chunk +2 lines, -5 lines 0 comments Download
M lib/html/frog/html_frog.dart View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kasperl
8 years, 5 months ago (2012-07-04 13:40:16 UTC) #1
Lasse Reichstein Nielsen
Drive-by comment. https://chromiumcodereview.appspot.com/10694082/diff/1/lib/compiler/implementation/native_handler.dart File lib/compiler/implementation/native_handler.dart (right): https://chromiumcodereview.appspot.com/10694082/diff/1/lib/compiler/implementation/native_handler.dart#newcode84 lib/compiler/implementation/native_handler.dart:84: library.define(compiler.findHelper(const SourceString('JS')), compiler); Maybe we should extend ...
8 years, 5 months ago (2012-07-04 13:49:44 UTC) #2
vsm
8 years, 5 months ago (2012-07-04 14:07:50 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698