Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 10694067: Make patch file import declarations apply to the patched library too. (Closed)

Created:
8 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
8 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make patch file import declarations apply to the patched library too. Add a math library and apply patching to that, instead of to the web library. We still have a default Math class with the same functionality, which isn't patched. Committed: https://code.google.com/p/dart/source/detail?r=9346

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review comment. Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -36 lines) Patch
M lib/compiler/implementation/compiler.dart View 1 3 chunks +31 lines, -1 line 0 comments Download
M lib/compiler/implementation/elements/elements.dart View 1 1 chunk +8 lines, -1 line 0 comments Download
A lib/compiler/implementation/lib/math.dartp View 1 chunk +12 lines, -0 lines 0 comments Download
D lib/compiler/implementation/lib/web.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D lib/compiler/implementation/lib/web.dartp View 1 chunk +0 lines, -13 lines 0 comments Download
M lib/compiler/implementation/library_map.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M lib/compiler/implementation/scanner/scanner_task.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + tests/compiler/dart2js_extra/math_lib_prefix_test.dart View 1 chunk +3 lines, -4 lines 0 comments Download
A + tests/compiler/dart2js_extra/math_lib_test.dart View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lasse Reichstein Nielsen
8 years, 5 months ago (2012-07-03 10:48:01 UTC) #1
Johnni Winther
lgtm https://chromiumcodereview.appspot.com/10694067/diff/1/lib/compiler/implementation/compiler.dart File lib/compiler/implementation/compiler.dart (right): https://chromiumcodereview.appspot.com/10694067/diff/1/lib/compiler/implementation/compiler.dart#newcode274 lib/compiler/implementation/compiler.dart:274: } catch (var doubleFault) {} Move the ending ...
8 years, 5 months ago (2012-07-03 11:04:29 UTC) #2
floitsch
LGTM. https://chromiumcodereview.appspot.com/10694067/diff/1/lib/compiler/implementation/compiler.dart File lib/compiler/implementation/compiler.dart (right): https://chromiumcodereview.appspot.com/10694067/diff/1/lib/compiler/implementation/compiler.dart#newcode568 lib/compiler/implementation/compiler.dart:568: if (resolved.scheme == "dart") { I would prefer ...
8 years, 5 months ago (2012-07-03 12:06:55 UTC) #3
Lasse Reichstein Nielsen
https://chromiumcodereview.appspot.com/10694067/diff/1/lib/compiler/implementation/compiler.dart File lib/compiler/implementation/compiler.dart (right): https://chromiumcodereview.appspot.com/10694067/diff/1/lib/compiler/implementation/compiler.dart#newcode568 lib/compiler/implementation/compiler.dart:568: if (resolved.scheme == "dart") { This is not a ...
8 years, 5 months ago (2012-07-03 12:55:04 UTC) #4
Lasse Reichstein Nielsen
8 years, 5 months ago (2012-07-03 13:01:03 UTC) #5
https://chromiumcodereview.appspot.com/10694067/diff/1/lib/compiler/implement...
File lib/compiler/implementation/compiler.dart (right):

https://chromiumcodereview.appspot.com/10694067/diff/1/lib/compiler/implement...
lib/compiler/implementation/compiler.dart:274: } catch (var doubleFault) {}
On 2012/07/03 11:04:29, Johnni Winther wrote:
> Move the ending } to a new line and insert a comment like 
> // Ignore double faults.
> in the catch block.

Done.

Powered by Google App Engine
This is Rietveld 408576698