Issue 10694053: Fix bailing out of SSA compilation and enable --use-ssa on x64 by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10694053: Fix bailing out of SSA compilation and enable --use-ssa on x64 by default. (Closed)

Created:
8 years, 5 months ago by Florian Schneider

Modified:
8 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Fix bailing out of SSA compilation and enable --use-ssa on x64 by default. We need to re-parse the function when retrying compilation after bailing out because of the side-effects to the AST (break-, continue-labels). To improve test coverage I'm enbabling building of SSA on x64 now. Committed: https://code.google.com/p/dart/source/detail?r=9291

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	vm/compiler.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	vm/flow_graph_builder.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages