Issue 10694023: update isolate.status: triagge what works and what doesn't work in dart2js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10694023: update isolate.status: triagge what works and what doesn't work in dart2js (Closed)

Created:
8 years, 5 months ago by Siggi Cherem (dart-lang)

Modified:
8 years, 5 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org, samhop, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

update isolate.status: triagge what works and what doesn't work in dart2js Committed: https://code.google.com/p/dart/source/detail?r=9219

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -12 lines)			Patch
	M	tests/isolate/isolate.status	View		2 chunks	+15 lines, -5 lines	0 comments	Download
	M	tests/isolate/v2_compute_this_script_browser_test.dart	View		1 chunk	+10 lines, -7 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

Seems like spawnFunction works w/o using workers. The library expect some initialization that is not ...

8 years, 5 months ago (2012-06-28 20:19:31 UTC) #1

Emily Fortuna

8 years, 5 months ago (2012-06-28 20:47:29 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10694023/diff/1/tests/isolate/v2_compu...
File tests/isolate/v2_compute_this_script_browser_test.dart (right):

https://chromiumcodereview.appspot.com/10694023/diff/1/tests/isolate/v2_compu...
tests/isolate/v2_compute_this_script_browser_test.dart:18: reply.send('re:
$msg');
oh no, no longer the handy => syntax! ;-)

Expand Messages | Collapse Messages